From: LorenzoPegorari Date: Mon, 01 Jun 2026 13:52:01 GMT Subject: [PATCH v3 1/2] http: cleanup function fetch_and_setup_pack_index() Message-ID: In-Reply-To: Cleanup the function `fetch_and_setup_pack_index()` by removing the useless call to the function `unlink()`. This is not necessary anymore since 63aca3f7f1 (dumb-http: store downloaded pack idx as tempfile, 2024-10-25), when `fetch_pack_index()` started registering its return value (in this case `tmp_idx`) as a tempfile to be deleted at process exit. Signed-off-by: LorenzoPegorari --- http.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/http.c b/http.c index 67c9c6fc60..b8443b1ef4 100644 --- a/http.c +++ b/http.c @@ -2538,9 +2538,7 @@ static int fetch_and_setup_pack_index(struct packfile_list *packs, new_pack = parse_pack_index(the_repository, sha1, tmp_idx); if (!new_pack) { - unlink(tmp_idx); free(tmp_idx); - return -1; /* parse_pack_index() already issued error message */ } -- 2.54.0.129.g2dffd77b94.dirty