From: David Turner <david.turner@twosigma.com>
Date: Wed, 16 Nov 2016 00:14:05 GMT
Subject: RE: [PATCH 07/16] update submodules: introduce submodule_is_interesting
Message-ID: <e748abfad8b04a8eaaa10797d9324891@exmbdft7.ad.twosigma.com>
In-Reply-To: <20161115230651.23953-8-sbeller@google.com>

> -----Original Message-----
> From: Stefan Beller [mailto:sbeller@google.com]
> Sent: Tuesday, November 15, 2016 6:07 PM
> Cc: git@vger.kernel.org; bmwill@google.com; gitster@pobox.com;
> jrnieder@gmail.com; mogulguy10@gmail.com; David Turner; Stefan Beller
> Subject: [PATCH 07/16] update submodules: introduce
> submodule_is_interesting
> +int submodule_is_interesting(const char *path, const unsigned char
> +*sha1) {

This is apparently only ever (in this series) called with null_sha1.  So either this arg is unnecessary, or there are bugs elsewhere in the code.