From: Johannes Sixt Date: Sat, 06 Jun 2026 09:38:02 GMT Subject: Re: [PATCH v3] git-gui: silence install recipes under "make -s" Message-ID: In-Reply-To: Am 04.06.26 um 08:48 schrieb Harald Nordgren via GitGitGadget: > From: Harald Nordgren > > Several install and uninstall recipes embed "echo" calls that fire as > part of the recipe itself, so the install banners (DEST, INSTALL, > LINK, REMOVE) were visible whenever the variables expand non-empty. > > Guard the whole "ifndef V" block on "-s" so the loud variants are > selected only when "-s" is absent and V=1 is unset. The existing > "-s" check also had its findstring arguments in the wrong order > (needle "-s" never fit in haystack "s"), so swap them while moving > the check to wrap the block. > > Signed-off-by: Harald Nordgren The new text looks good. However, the email addresses of author and signer-off are different. They should be the same. I notice that you use the gmail address in both places in other patch submissions, so I can use that if you agree (and you don't need to send another round). -- Hannes