From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 18 Jul 2015 06:58:50 GMT
Subject: Re: [PATCH v2] Fix detection of uname failure
Message-ID: <e6959e1763d2f5cb2d14618a61edfab9@www.dscho.org>
In-Reply-To: <xmqq7fpy1n0z.fsf@gitster.dls.corp.google.com>

Hi Junio,

On 2015-07-17 23:39, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
>> On 2015-07-17 19:09, Charles Bailey wrote:
>>> From: Charles Bailey <cbailey32@bloomberg.net>
>>>
>>> According to POSIX specification uname must return -1 on failure and a
>>> non-negative value on success. Although many implementations do return 0
>>> on success it is valid to return any positive value for success.  In
>>> particular, Solaris returns 1.
>>>
>>> Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
>>
>> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> I'd s/Ack/Review/; as the original is not your code but you are well
> qualified (and have my trust) to judge the change to this codepath
> ;-)

Yeah, that's what I meant ;-)

Ciao,
Dscho