From: Kevin Leung <kevinlsk@gmail.com>
Date: Sun, 10 Jan 2010 13:52:53 GMT
Subject: Re: [PATCH] git-p4: Fix empty submit template when editor fires up
Message-ID: <e66701d41001100552p6cf2fde8m6463613cfcc4315b@mail.gmail.com>
In-Reply-To: <20100110111440.GB19612@progeny.tock>

On Sun, Jan 10, 2010 at 7:14 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Jonathan Nieder wrote:
>> Kevin Leung wrote:
>> > read_pipe() returns "\n". We need to remove it before passing it
>> > to system().
>> >
>> > Signed-off-by: Kevin Leung <kevinlsk@gmail.com>
>>
>> If I understand correctly, this is a cosmetic change:
>
> ... and of course I didn't the subject.  Sorry about that.  Thanks
> for cleaning up my mess.
>
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
>
>> What is the rationale for the rewritten system() line?  I would have
>> understood a change to
>>
>>       os.spawnlp("sh", "-c", editor + " \"$@\"", fileName)
>
> I am still curious about this, though it is not so important.

You are right, the system() line is not so important. I can revert
that line of change.

Kevin