From: Kaartic Sivaraam Date: Thu, 15 Oct 2026 08:36:30 GMT Subject: Re: [PATCH v4 3/8] ci: drop unused "linux-clang" logic Message-ID: In-Reply-To: <20261015-pks-ci-housekeeping-v4-3-c2c88f1b198e@pks.im> On 10/15/26 12:27, Patrick Steinhardt wrote: > In d88d727143 (ci: drop linux-clang job, 2023-06-01) we have dropped the > "linux-clang" job because another job already uses Clang anyway. But we > forgot to also drop the logic in "ci/run-build-and-tests.sh", so we now > have some unused logic in there. > > Drop it. > > Signed-off-by: Patrick Steinhardt > --- > ci/run-build-and-tests.sh | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh > index bc5058c917..23e87cbbd6 100755 > --- a/ci/run-build-and-tests.sh > +++ b/ci/run-build-and-tests.sh > @@ -37,10 +37,6 @@ linux-TEST-vars) > export GIT_TEST_CHECKOUT_WORKERS=2 > export GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL=1 > ;; > -linux-clang) > - export NO_RUST=UnfortunatelyYes > - export GIT_TEST_DEFAULT_HASH=sha1 > - ;; I know we're removing this only because we lost the job already 3 years ago. I just wanted to check a bit more on seeing the job had a NO_RUST flag on. On some digging, it seems that 32d5b90590 (Enable Rust by default, 2026-04-09) flipped Rust flags of CI jobs and retained NO_RUST only for this job and the linux-musl-meson jobs. That means, we've been having the NO_RUST flag on a Makefile based job that never existed in the first place which is a bit sad. I wonder if we need to fix the intention at least now and slip the NO_RUST flag into one of the other Makefile based jobs? linux-feature-testbed? Or have a separate job for this? Of course, this is not really a problem with this series per se. So, we can handle it separately if that's preferred. Happy to hear thoughts either way. -- Sivaraam