From: Marco Costalba Date: Sat, 05 Jan 2008 22:55:37 GMT Subject: [PATCH] Fix an off by one bug in pretty.c Message-ID: In case author email is <> then we have the following bug in function 'format_person_part' /* parse name */ for (end = 0; end < len && msg[end] != '<'; end++) ; /* do nothing */ start = end + 1; /* now start points to '>' */ -- cut --- /* parse email */ for (end = start + 1; end < len && msg[end] != '>'; end++) And here 'end' is initialized with 'start + 1' instead of 'start'. This turns out in empty commit date when git log is used with --pretty=format option. Signed-off-by: Marco Costalba --- pretty.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pretty.c b/pretty.c index 5b1078b..0b2f187 100644 --- a/pretty.c +++ b/pretty.c @@ -292,7 +292,7 @@ static void format_person_part /* parse name */ for (end = 0; end < len && msg[end] != '<'; end++) ; /* do nothing */ - start = end + 1; + start = end; while (end > 0 && isspace(msg[end - 1])) end--; if (part == 'n') { /* name */ -- 1.5.4.rc2.38.gd6da3-dirty