From: Marco Costalba Date: Sat, 29 Dec 2007 20:39:47 GMT Subject: Re: [PATCH] Optimize prefixcmp() Message-ID: In-Reply-To: On Dec 29, 2007 8:22 PM, Johannes Schindelin wrote: > > Not only does it avoid the strlen() call also for longer prefixes; > it also avoids a C++ comment. > Avoiding a C++ comment is good ;-) sorry, it slipped to me. What your patch does not seem to avoid is a segfault if prefix or str are NULL pointers. Marco