From: Marco Costalba <mcostalba@gmail.com>
Date: Thu, 16 Aug 2007 08:11:00 GMT
Subject: Re: [PATCH] Fix an unitialized pointer in merge-recursive.c
Message-ID: <e5bfff550708160111n66b5ea94k26cf2fecc06fd84c@mail.gmail.com>
In-Reply-To: <7vsl6jkila.fsf@gitster.siamese.dyndns.org>

On 8/16/07, Junio C Hamano <gitster@pobox.com> wrote:
> "Marco Costalba" <mcostalba@gmail.com> writes:
>
> > Indeed &mrtree is passed to merge_trees() that not always
> > seems to set the value, so on some paths mrtree could
> > return uninitialized.
> >
> > Spotted by a gcc 4.2.1 warning
>
> Are you sure that gcc is correctly seeing the codeflow?
>
> In merge(), mrtree is used only under index_only, and
> merge_trees() always sets *result under index_only.
>

Ok ;-)

Now two options:

- discard the patch

- change the title in 'silence a gcc bougus warning'