From: Marco Costalba <mcostalba@gmail.com>
Date: Tue, 01 May 2007 19:59:34 GMT
Subject: Re: [StGIT RFC PATCH] Don't use refs/bases/<branchname>
Message-ID: <e5bfff550705011259w567a98dj6d0a68b0fbe90994@mail.gmail.com>
In-Reply-To: <20070501185615.GA32727@diana.vm.bytemark.co.uk>

On 5/1/07, Karl Hasselström <kha@treskal.com> wrote:
> On 2007-05-01 11:10:47 +0200, Marco Costalba wrote:
>
> > The only StGit data read directly are patches sha's; qgit walks
> > recursively all the files called "top" under directory tree
> >
> >           <git dir>/patches/<current branch>
> >
> > to get sha list of each applied and unapplied patch in one go. This
> > is much faster then calling "stg id <patch name>" for all the
> > patches.
>
> Hmm. These are on my kill list too. :-)
>
> The patch tops are already recorded in
> refs/patches/<branch>/<patchname> to keep them from being garbage
> collected, so these top files are redundant. But it isn't _that_ bad,
> so if removing them would break qgit, I guess I could try to restrain
> myself. At least all the other metadata is fair game. :-)
>
> (But if I were you, I'd look for the patches under patches/refs
> anyway; they _have_ to be there to survive garbage collection, so no
> amount of stgit refactoring will break qgit.)
>

Well, I did. ;-)

Actually I pushed a patch few hours  ago to read patches sha under refs/patches.

The problem is that the patch (for now) is pushed only for the new
development version of qgit, not the stable one and, worse, all the
currently released versions will break if you remove  <git
dir>/patches/ directory.

So please, if possible deprecate  <git dir>/patches/ directory but do
not remove for a while, so to let users to upgrade gracefully.

Thanks
Marco