From: Marco Costalba Date: Sat, 21 Apr 2007 10:03:38 GMT Subject: Re: Possible bug in --short option of git-rev-list Message-ID: In-Reply-To: <7vps5yul49.fsf@assigned-by-dhcp.cox.net> On 4/21/07, Junio C Hamano wrote: > > Short is abbrev + verify. This is not new. > In my implementation I pass command line arguments first to git-rev-parse, and the output of git-rev-parse is then used to feed git-rev-list, that starts loading of revisions. The problem I found is that output of git-rev-parse could be veeery long, as example in git tree: $ git rev-parse --all | wc 144 144 5904 When running qgit --all on a repo with hundreds of tags this could lead to very long command line arguments for git-rev-list so to break platform limits. One idea to *hide* this problem was to get only the short version of a sha so to go from 40 to 7 chars and reduce command line size of about 6 times. Of course the *real* solution would be to pass qgit command line arguments directly to git-rev-list and skip git-rev-parse altogether. My question is: In case I skip git-rev-parse and feed directly git-rev-list with command line arguments, there is some compatibility break in current behaviour? In other words there are some command line arguments 'args' for whom git-rev-list args != git rev-parse args | git rev-list Thanks Marco