From: phillip.wood123@gmail.com Date: Thu, 21 Dec 2023 15:09:59 GMT Subject: Re: [PATCH 4/8] SubmittingPatches: update extra tags list Message-ID: In-Reply-To: Hi Josh On 20/12/2023 17:42, Josh Soref wrote: > SubmittingPatches: discourage new trailers > > There seems to be consensus amongst the core Git community on a working > set of common trailers, and there are non-trivial costs to people > inventing new trailers (research to discover what they mean/how they > differ from existing trailers) such that inventing new ones is generally > unwarranted and not something to be recommended to new contributors. > > Suggested-by: Elijah Newren > Signed-off-by: Josh Soref > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index 32e9023877..58dfe40504 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -358,4 +358,5 @@ If you like, you can put extra tags at the end: > > -You can also create your own tag or use one that's in common usage > -such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:". > +While you can also create your own trailer if the situation warrants it, we > +encourage you to instead use one of the common trailers in this project > +highlighted above. Thanks for this, it looks good and would be a useful addition to v2 of your patch series. Best Wishes Phillip