From: Jakub Narebski <jnareb@gmail.com>
Date: Sun, 07 May 2006 18:28:25 GMT
Subject: Re: [PATCH] Transitively read alternatives
Message-ID: <e3le7q$eli$1@sea.gmane.org>
In-Reply-To: <20060507181920.GC23738@admingilde.org>

Martin Waitz wrote:

> When adding an alternate object store then add entries from its
> info/alternates files, too.
> Relative entries are only allowed in the current repository.
> Loops and duplicate alternates through multiple repositories are ignored.
> Just to be sure that nothing breaks it is not allow to build deep
> nesting levels using info/alternates.

> +     if (depth > 5) {
> +             error("%s: ignoring alternate object stores, nesting too deep.",
> +                             relative_base);
> +             return;
> +     }

Please, no magic numbers. Use preprocesor "constants" for that.

-- 
Jakub Narebski
Warsaw, Poland