From: Derrick Stolee Date: Fri, 04 Oct 2024 19:27:14 GMT Subject: Re: [PATCH 0/5] diff output_prefix cleanups Message-ID: In-Reply-To: <20241003210548.GB11180@coredump.intra.peff.net> On 10/3/24 5:05 PM, Jeff King wrote: > On Thu, Oct 03, 2024 at 11:58:41AM +0000, Derrick Stolee via GitGitGadget wrote: >> Note to the maintainer: feel free to take only the first patch, as Peff >> replied that he may work on the remaining cleanup independently (but I had >> already prepared patches 2 & 3). > > Oh, I wasn't expecting you to go to that trouble, and had already > polished them up myself. :) It's perfectly fine that we were attempting to save each other work. > So certainly your patch 1 looks good to me now. Here's what I would > put on top (but I would suggest making it a separate branch, since yours > is a fairly urgent fix and mine is all cleanup). I approve of this plan. Please only consider my first patch and drop the others. Thanks, -Stolee