From: Philip Oakley Date: Thu, 24 Oct 2019 11:04:02 GMT Subject: Re: [PATCH 1/1] repo-settings: read an int for index.version Message-ID: In-Reply-To: <095b43f606a352527c9e0551adbd8a6af2061176.1571863137.git.gitgitgadget@gmail.com> spelling nit. On 23/10/2019 21:38, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > Several config options were combined into a repo_settings struct in > ds/feature-macros, including a move of the "index.version" config > setting in 7211b9e (repo-settings: consolidate some config settings, > 2019-08-13). > > Unfortunately, that file looked like a lot of boilerplate and what is > clearly a factor of copy-paste overload, the config setting is parsed > with repo_config_ge_bool() instead of repo_config_get_int(). This means s/_ge_bool()/_get_bool()/ > that a setting "index.version=4" would not register correctly and would > revert to the default version of 3. > > I caught this while incorporating v2.24.0-rc0 into the VFS for Git > codebase, where we really care that the index is in version 4. > > This was not caught by the codebase because the version checks placed > in t1600-index.sh did not test the "basic" scenario enough. Here, we > modify the test to include these normal settings to not be overridden by > features.manyFiles or GIT_INDEX_VERSION. While the "default" version is > 3, this is demoted to version 2 in do_write_index() when not necessary. > > Signed-off-by: Derrick Stolee > --- Philip