From: Johannes Schindelin via GitGitGadget Date: Tue, 25 Mar 2025 08:01:49 GMT Subject: [PATCH 1/2] remote-curl: avoid using the comma operator unnecessarily Message-ID: In-Reply-To: From: Johannes Schindelin The comma operator is a somewhat obscure C feature that is often used by mistake and can even cause unintentional code flow. Better use a semicolon instead. Signed-off-by: Johannes Schindelin --- remote-curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/remote-curl.c b/remote-curl.c index 1273507a96c..57b515b37e7 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -1401,7 +1401,7 @@ static int push_git(struct discovery *heads, int nr_spec, const char **specs) packet_buf_flush(&preamble); memset(&rpc, 0, sizeof(rpc)); - rpc.service_name = "git-receive-pack", + rpc.service_name = "git-receive-pack"; err = rpc_service(&rpc, heads, args.v, &preamble, &rpc_result); if (rpc_result.len) -- gitgitgadget