From: Dragan Simic Date: Mon, 10 Jun 2024 21:16:40 GMT Subject: Re: [PATCH v3 0/6] use the pager in 'add -p' Message-ID: In-Reply-To: On 2024-06-10 22:08, Junio C Hamano wrote: > Dragan Simic writes: > >> If you want to see an example of the garbled output, as a result of >> the >> coloring escape sequences not being processed correctly, just "cd" >> into >> your favorite Git repository and run the following commands (assuming >> you're using bash, if not, please adjust the first command): >> >> export GIT_PAGER='less' >> git log --patch >> >> I hope that will make more clear why I'm "advocating" for three >> separate >> new commands for "git add -p", i.e. "P", "|xyz" and ">xyz". > > We are talking about folks who use a pager in the context of Git, > and to them, your example is totally made-up and irrelevant one. Ah, that wasn't my intention. I just wanted to provide an example that shows what a garbled output looks like, because I was under impression that Phillip asked for such an example. > Either they use a color-enabled pager (like "less -R") or they have > configured color.ui to disable coloring. So I do not see this quite > as a safety issue. Agreed, but only if we end up honoring "color.ui" and "color.diff" in the new "git add -p" command(s).