From: Mike Ralphson <mike.ralphson@gmail.com>
Date: Wed, 17 Jun 2009 13:15:54 GMT
Subject: Re: [PATCH v2 2/2] Makefile: use compat regex on Solaris
Message-ID: <e2b179460906170615u46a71241wf012d98020ef91e0@mail.gmail.com>
In-Reply-To: <20090616190821.GB23197@coredump.intra.peff.net>

2009/6/16 Jeff King <peff@peff.net>
>
> The system regex is either slow or buggy for complex
> patterns, like the built-in xfuncname pattern for java
> files.

Also required on AIX (5.3). I thought this was a major performance
regression somewhere else, but my 'old stable' version dates from a
time when we were briefly using compat/regex on this platform before
we reverted that change and switched over to extended regexes.

With the above:
3m33.399s

Without:
... manually aborted after 58m !

git 1.6.0.2.229.g1293c
3m21.645s

Could you squash

+       NO_REGEX = YesPlease

in ifeq ($(uname_S),AIX) please? Shout if follow-up patch preferred.

Signed-off-by: Mike Ralphson <mike@abacus.co.uk>

Mike

PS Pound to a penny INTERNAL_QSORT would be a win on Solaris too...