From: Mike Ralphson Date: Mon, 01 Dec 2008 09:57:56 GMT Subject: Re: [PATCH] Makefile: introduce NO_PTHREADS Message-ID: In-Reply-To: <4933A058.3050101@viscovery.net> 2008/12/1 Johannes Sixt > > Johannes Sixt schrieb: > > Mike Ralphson schrieb: > >> 2008/11/17 Johannes Sixt : > >>> Mike Ralphson schrieb: > >>>> 2008/11/15 Linus Torvalds : > >>>>> On Sat, 15 Nov 2008, Junio C Hamano wrote: > >>>>>> This introduces make variable NO_PTHREADS for platforms that lack the > >>>>>> support for pthreads library or people who do not want to use it for > >>>>>> whatever reason. When defined, it makes the multi-threaded index > >>>>>> preloading into a no-op, and also disables threaded delta searching by > >>>>>> pack-objects. > >>>>> ... > > > > :-( Maybe NO_PTHREADS is indeed the safer choice? I'm not going to dig > > into this today, though. (I'm on AIX 4.3.something.) > > > >>> BTW, this needs to be squashed in, because we don't have pthreads on Windows: > >>>... > > you said you would resend the patch, but I think you forgot about it. > Would you do that now, please? Not forgotten, just slow. The current state I believe is we should have NO_PTHREADS for AIX < v5. THREADED_DELTA_SEARCH and the new multi-threaded lstat are actually ok on AIX 5.3 at least - though I couldn't see any performance benefit on my repo / hardware combination. But now after dhruva's observation I'm unsure what the desired change is for Windows. 8-( Mike