From: Mike Ralphson Date: Wed, 20 Aug 2008 11:36:06 GMT Subject: Re: [PATCH] test-lib.sh: work around ksh's trap shortcomings Message-ID: In-Reply-To: 2008/8/20 Brandon Casey > > Brandon Casey wrote: > > Junio C Hamano wrote: > >> Your alias test_done that calls function test_done look ugly and confusing > >> beyond words. Perhaps test_done() can instead set a global variable and > >> die() can notice it instead, like this? I haven't bothered to change the > >> other "trap - exit" but I think you got the idea... > > > > Yes that works and is much clearer. Tested on solaris and irix. > > I spoke too soon. Failing tests do not terminate the testing. > > ksh does not place the exit status of the shell in $? or provide it as an argument > to the trap function. ... it looks like the status of the command executed immediately before > exit is what the trap has access to in $?. Adding a call to false before exit > in the above script causes the korn scripts to exit with status 1 on IRIX and > SunOS. Just to report the same findings with AIX 5.3's /bin/sh (which is /bin/ksh), /bin/ksh93 and even /bin/bsh Mike