From: Mike Ralphson <mike.ralphson@gmail.com>
Date: Fri, 08 Feb 2008 17:25:52 GMT
Subject: Re: [PATCH] opening files in remote.c should ensure it is opening a file
Message-ID: <e2b179460802080925s61270036q81896010c76236ae@mail.gmail.com>
In-Reply-To: <20080208174654.2e9e679c@pc09.procura.nl>

On Feb 8, 2008 4:46 PM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:
> HP-UX allows directories to be opened with fopen (path, "r"), which
> will cause some translations that expect to read files, read dirs
> instead. This patch makes sure the two fopen () calls in remote.c
> only open the file if it is a file.
>
> Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

Many thanks, this is also required for AIX. I had got some way to
tracking it down, but I thought it was an issue with strbuf. So...

Tested-by: Mike Ralphson <mike.ralphson@gmail.com>

Your other fix there [- if (!strbuf_avail(sb)) / + if
(strbuf_avail(sb) < 64) ] is, guess what, also required on AIX.

Thanks again.