From: phillip.wood123@gmail.com
Date: Thu, 18 Jul 2024 09:48:28 GMT
Subject: Re: [PATCH v3 4/4] add-patch: render hunks through the pager
Message-ID: <e2532dee-5d16-484e-ba13-840af7b47c27@gmail.com>
In-Reply-To: <xmqqfrs723bp.fsf@gitster.g>

On 17/07/2024 21:03, Junio C Hamano wrote:
> phillip.wood123@gmail.com writes:
> 
>>> -	test_write_lines P q | GIT_PAGER="head -n 1" test_terminal git add -p
>>> +	test_write_lines P q |
>>> +	(
>>> +		GIT_PAGER="head -n 1" &&
>>> +		export GIT_PAGER &&
>>> +		test_terminal git add -p >actual
>>> +	)
>>
>> That's surprising, why does running git in a sub-shell stop it from
>> segfaulting?
> 
> Yeah, it indeed is curious.
> 
> The rewrite resolves another iffy point in the original---you are
> not supposed to attempt a one-shot assignment to the environment
> variable when you are running a shell function, as that is not
> portable.  And the above rewrite is a common way to fix that.

Good point, I'd not thought of that.

Best Wishes

Phillip