From: Alexey Borzenkov <snaury@gmail.com>
Date: Tue, 15 Sep 2009 19:01:43 GMT
Subject: Re: [PATCH 04/14] Set _O_BINARY as default fmode for both MinGW and MSVC
Message-ID: <e2480c70909151201t2b23698xb0925fbbebf55ce5@mail.gmail.com>
In-Reply-To: <badc5d24387c28c752a45f75e8aec6bce64f81fe.1253021728.git.mstormo@gmail.com>

On Tue, Sep 15, 2009 at 5:44 PM, Marius Storm-Olsen <mstormo@gmail.com> wrote:
> +extern int _fmode;

And indeed. I just ported this patch to my custom msysgit branch
(based on v1.6.4.3) and it didn't compile:

    CC git.o
cc1.exe: warnings being treated as errors
In file included from git-compat-util.h:116,
                 from builtin.h:4,
                 from git.c:1:
compat/mingw.h:243: error: '_fmode' redeclared without dllimport
attribute: previous dllimport ignored
git.c: In function 'main':
git.c:456: error: the address of '_iob' will always evaluate as 'true'
make: *** [git.o] Error 1