From: Phillip Wood Date: Fri, 22 Nov 2024 16:44:41 GMT Subject: Re: [PATCH v4 2/8] worktree: add `relativeWorktrees` extension Message-ID: In-Reply-To: Hi Caleb On 20/11/2024 05:13, Caleb White wrote: > On Tue Nov 19, 2024 at 9:07 AM CST, Phillip Wood wrote: >> On 01/11/2024 04:38, Caleb White wrote: >>> A new extension, `relativeWorktrees`, is added to indicate that at least >>> one worktree in the repository has been linked with relative paths. >> >> Out of interest what happens in the later patches if we add a worktree >> with a relative path which sets this extension and then convert it to an >> absolute path? Will we clear this extension or do we leave it set? I'm >> mainly curious, I don't think it's the end of the world if we leave the >> extension set. > > The extension would remain set. I was going to try and unset the > extension, but it is only safe to do that if all worktrees use absolute > (meaning they would all need to be checked) and I decided it wasn't that > important. Yes, I don't think we need to do that just now I suppose the check could be added in the `repair_worktrees()` > function during `git worktree repair` if it is deemed important. That could be a nice addition in the future Best Wishes Phillip > > Best, > > Caleb >