From: Phillip Wood <phillip.wood123@gmail.com>
Date: Wed, 10 Jun 2026 09:33:56 GMT
Subject: Re: [PATCH RFC v2 2/2] builtin/history: abort reword on same message
Message-ID: <e033b216-d8e7-4c16-8fb5-0455125b71a3@gmail.com>
In-Reply-To: <aikMLBCC9Rc7q9S7@pks.im>

Hi Patrick

On 10/06/2026 08:03, Patrick Steinhardt wrote:
> On Tue, Jun 09, 2026 at 12:17:51PM -0700, Junio C Hamano wrote:
>> Pablo Sabater <pabloosabaterr@gmail.com> writes:
>>
>>>>> I wonder if we should check that the committer identity is unchanged as
>>>>> well in case anyone is using this to fix commits after committing with
>>>>> the wrong identity.
>>>
>>> I think that if you reword a commit committed by someone else but end
>>> up with no changes I want it to be kept as it was.
>>
>> That depends on the reason why the feature to "reword" the commit is
>> being used, and the use case Phillip is talking about is a bit
>> different.
> 
> So the answer is "it depends". Maybe we should do handle this the same
> as git-commit(1) does with its "--reset-author" flag?

For the case I was talking about we'd want to reset the committer but I 
agree that making "reset the committer" explicit and just comparing the 
old and new messages when deciding whether to skip rewriting is a good 
way forward.

Thanks

Phillip