From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Fri, 30 Jan 2026 19:51:21 GMT
Subject: Re: [PATCH 2/2] string-list: add string_list_sort_u() that mimics "sort -u"
Message-ID: <e01f307c-3d7e-41b2-b62a-f61b1dd17640@app.fastmail.com>
In-Reply-To: <20260125201500.63904-2-amishhhaaaa@gmail.com>

On Sun, Jan 25, 2026, at 21:15, Amisha Chhajed wrote:
> Many callsites of string_list_remove_duplicates() call it
> immdediately after calling string_list_sort(), understandably

nit: s/immdediately/immediately

> as the former requires string-list to be sorted, it is clear
> that these places are sorting only to remove duplicates and
> for no other reason.
>
> Introduce a helper function string_list_sort_u that combines
> these two calls that often appear together, to simplify
> these callsites. Replace the current calls of those methods with
> string_list_sort_u().
>
> Signed-off-by: Amisha Chhajed <amishhhaaaa@gmail.com>
> ---
>[snip]