From: Josh Steadmon <steadmon@google.com>
Date: Tue, 16 Dec 2025 23:20:48 GMT
Subject: Re: [PATCH v6 00/10] Add submodulePathConfig extension and gitdir encoding
Message-ID: <dymehf7vjf6winlsezdzbdiboo7d74wezoopwkyc67ckra7oe2@5ruvpsgjpbea>
In-Reply-To: <20251213080817.347922-1-adrian.ratiu@collabora.com>

On 2025.12.13 10:08, Adrian Ratiu wrote:
> Hello everyone,
> 
> For those new to the series, we're implementing a submodule gitdir
> extension which allows us to have a unified way to determine gitdirs
> and do things like encode submodule paths to avoid FS conflicts.

I'm afraid I've gotten a bit lost with this series. IIUC, we no longer
try to encode submodule gitdirs by default, instead we do this only if
we detect a conflict with an existing gitdir. However, in all of my
local testing, I have been unable to produce a conflict that triggers
this encoding. Instead, everything hits the error:
  "fatal: A git directory for 'nested%2fsub' is found locally with remote(s):"
from `builtin/submodule--helper.c:3389`.

This happens regardless of the setting of
`extensions.submodulepathconfig` in either the repo's local config, or
my user config.

My testing setup has been as follows:
* Using our locally-built Git with our downstream patch of [1] included:
  * create a repo "sub"
  * create a repo "super"
  * In "super":
    * mkdir nested
    * git submodule add ../sub nested/sub
    * Verify that the submodule's gitdir is .git/modules/nested%2fsub
* Using a build of git from upstream `next` plus this series:
  * git config set --global extensions.submodulepathconfig true
  * git clone --recurse-submodules super super2
  * create a repo "nested%2fsub"
  * In "super2":
    * git submodule add ../nested%2fsub

At this point I'd expect the collision detection / encoding to take
effect, but instead I get the error listed above.


[1] https://lore.kernel.org/git/20180807230637.247200-1-bmwill@google.com/