From: hsed@unimetic.com
Date: Mon, 20 Nov 2017 14:53:35 GMT
Subject: Re: [PATCH V4] config: add --expiry-date
Message-ID: <dfa89c0016cc857bee6d9c380c2b2679@unimetic.com>
In-Reply-To: <xmqq8tf4qmu8.fsf@gitster.mtv.corp.google.com>

On 2017-11-18 03:37, Junio C Hamano wrote:
> 
> I think this is more correct even within the context of this
> function than dying, which suggests the need for a slightly related
> (which is not within the scope of this change) clean-up within this
> file as a #leftoverbits task.  I think dying in these value parsers
> goes against the point of having die_on_error bit in the
> config-source structure; Heiko and Peff CC'ed for b2dc0945 ("do not
> die when error in config parsing of buf occurs", 2013-07-12).
> 
> Thanks; will queue.

Thanks a lot for all your help and I hope to do more patches in future!

Kind Regards,
Haaris