From: Derrick Stolee Date: Thu, 11 Oct 2018 11:16:10 GMT Subject: Re: What's cooking in git.git (Oct 2018, #01; Wed, 10) Message-ID: In-Reply-To: On 10/10/2018 1:43 AM, Junio C Hamano wrote: > > * ds/reachable-topo-order (2018-09-21) 7 commits > - revision.c: refactor basic topo-order logic > - revision.h: add whitespace in flag definitions > - commit/revisions: bookkeeping before refactoring > - revision.c: begin refactoring --topo-order logic > - test-reach: add rev-list tests > - test-reach: add run_three_modes method > - prio-queue: add 'peek' operation > > The revision walker machinery learned to take advantage of the > commit generation numbers stored in the commit-graph file. > > What's the status of this topic? I've reached out for review, especially on the rather large patch "revision.c: refactor basic topo-order logic" but have received no messages about it. I don't think anyone has even done a cursory style review. I really think that this is a valuable topic, and it would be nice to have in 2.20, but I'm not pushing to merge something that no one has reviewed. > * ds/format-commit-graph-docs (2018-08-21) 2 commits > - commit-graph.txt: improve formatting for asciidoc > - Docs: Add commit-graph tech docs to Makefile > > Design docs for the commit-graph machinery is now made into HTML as > well as text. > > Will discard. > I am inclined to drop these, as I do not see much clarity in HTML > output over the text source. Opinions? These have been marked for discard for a few weeks. I agree they should be discarded. Thanks, -Stolee