From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 25 Oct 2018 21:04:58 GMT
Subject: Re: [PATCH sg/test-rebase-editor-fix] t3404-rebase-interactive: test abbreviated commands
Message-ID: <df45cad7-0290-f308-5463-e79cdd0ebea8@kdbg.org>
In-Reply-To: <94c0b5b6-ac31-101b-80a0-ac78196e0f62@kdbg.org>

Am 25.10.18 um 22:54 schrieb Johannes Sixt:
> Test each short command at least once. The commands changed here
> are chosen such that
> 
> - tests do not have a prerequisite,
> - the 'git rebase' command is not guarded by test_must_fail.
> 
> The pick commands are optional noise words in the FAKE_LINES
> variable. Test them, too.

Actually, this sentence should better be:

The pick commands are optional in the FAKE_LINES variable, but
when used, they do end up in the insn sheet. Test them, too.

> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
...
> @@ -732,7 +732,7 @@ test_expect_success 'reword' '
>   	git show HEAD^ | grep "D changed" &&
>   	FAKE_LINES="reword 1 2 3 4" FAKE_COMMIT_MESSAGE="B changed" git rebase -i A &&
>   	git show HEAD~3 | grep "B changed" &&
> -	FAKE_LINES="1 reword 2 3 4" FAKE_COMMIT_MESSAGE="C changed" git rebase -i A &&
> +	FAKE_LINES="1 r 2 pick 3 p 4" FAKE_COMMIT_MESSAGE="C changed" git rebase -i A &&
>   	git show HEAD~2 | grep "C changed"
>   '