From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Date: Tue, 19 Nov 2019 16:52:17 GMT
Subject: Re: [PATCH v2 3/6] doc: reset: unify <pathspec> description
Message-ID: <df10e5bc-3e60-7fab-c66b-583a196a2423@syntevo.com>
In-Reply-To: <xmqqv9rgxuy1.fsf@gitster-ct.c.googlers.com>

On 19.11.2019 7:05, Junio C Hamano wrote:

>> -'git reset' [-q] [<tree-ish>] [--] <paths>...::
>> -	This form resets the index entries for all `<paths>` to their
>> +'git reset' [-q] [<tree-ish>] [--] <pathspec>...::
>> +	This form resets the index entries for all `<pathspec>` to their
> 
> This is not so good.  The original pretended as if <paths> are the
> exact pathnames, so it was sort-of OK for it to say "for all paths".
> Since we are highlighting the fact that these are not pathnames but
> the patterns to match pathnames, however, the description needs a
> slight update to match, perhaps like
> 
> 	ths form resets the index entries for all paths that match
> 	the `<pathspec>` to their...
> 
>>   	state at `<tree-ish>`.  (It does not affect the working tree or
>>   	the current branch.)

Yes, I wasn't paying enough attention.
Changed in V3, thanks!