From: Phillip Wood Date: Wed, 26 Jun 2024 15:21:01 GMT Subject: Re: [PATCH v4 0/2] Darcy's "date underflow fix" topic, final reroll Message-ID: In-Reply-To: <20240625231248.4070257-1-gitster@pobox.com> Hi Junio On 26/06/2024 00:12, Junio C Hamano wrote: > So it has been some time since we discussed this topic. Let's clean > up the messy "SQUASH???" patches I had to queue on top of the main > patch to keep the CI working and make them into a preliminary patch. > > The tree at the end of the series is identical to what has been > queued in 'seen' for the past few weeks. The only difference is > that we first lay groundwork to skip certain time-parsing tests on > 32-bit systems first, and then use Darcy's patch with minimum > adjustments for 32-bit systems. I've had a read through this verison and I don't have anything to add to Eric's comments. Best Wishes Phillip > Darcy Burke (1): > date: detect underflow/overflow when parsing dates with timezone offset > > Junio C Hamano (1): > t0006: simplify prerequisites > > date.c | 12 +++++++++++- > t/t0006-date.sh | 51 +++++++++++++++++++++++++++++++++++++++++++------ > 2 files changed, 56 insertions(+), 7 deletions(-) >