From: Garima Singh <garimasigit@gmail.com>
Date: Thu, 23 Apr 2020 22:14:36 GMT
Subject: Re: [PATCH 0/2] minor fixups for gs/commit-graph-path-filter
Message-ID: <dde036bb-303c-a9d1-6bf2-880428cfb7c0@gmail.com>
In-Reply-To: <20200423205851.GA1633985@coredump.intra.peff.net>


On 4/23/2020 4:58 PM, Jeff King wrote:
> These are just a few bits I noticed in the test-tool helper when the
> topic hit next (my -Wunused-parameter patch complained that we never
> looked at argc).
> 
>   [1/2]: test-bloom: fix some whitespace issues
>   [2/2]: test-bloom: check that we have expected arguments
> 
>  t/helper/test-bloom.c | 28 ++++++++++++++++++++--------
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 
> -Peff
> 

Thank you for doing this! 
Both patches look good to me. 
I also don't care about the brace/no-brace thing that 
Taylor brought up for 1/2. 

Cheers! 
Garima Singh