From: Brad Smith <brad@comstyle.com>
Date: Thu, 12 Jun 2025 03:54:11 GMT
Subject: Re: [PATCH] config.mak.uname: update settings for FreeBSD
Message-ID: <ddb50b73-8f98-48e5-880b-b991508edea3@comstyle.com>
In-Reply-To: <xmqqsek5fwnu.fsf@gitster.g>

On 2025-06-11 11:47 p.m., Junio C Hamano wrote:
> Brad Smith <brad@comstyle.com> writes:
>
>> FreeBSD 6.0 has memmem().
> And anything older than that no longer matters?

I look at is as so. 6.0 is 19.5 years old as it is.

> That may indeed be true (6.0 was from Nov 2005), but if that is the
> reason why we simply lose NO_MEMMEM (instead of conditionally losing
> for 6.0 and newer), that needs to be explained in the proposed log
> message, together with the reason why we no longer do anything
> special with version "4.x" (which could be "We ditch the support for
> anything older than 6.0").
>
> Assuming that our stance is "anything older than 6.0 no longer
> matters", the patch itself looks good.

This was my intent. I'll update the commit message.