From: Dragan Simic Date: Mon, 11 Mar 2024 17:34:41 GMT Subject: Re: [PATCH v2] config: add --comment option to add a comment Message-ID: In-Reply-To: On 2024-03-11 18:29, Junio C Hamano wrote: > Dragan Simic writes: >> On 2024-03-11 13:55, Junio C Hamano wrote: >>> "Ralph Seichter via GitGitGadget" writes: >>> >>>> From: Ralph Seichter >>>> Introduce the ability to append comments to modifications >>>> made using git-config. Example usage: >>>> git config --comment "changed via script" \ >>>> --add safe.directory /home/alice/repo.git >>>> based on the proposed patch, the output produced is: >>>> [safe] >>>> directory = /home/alice/repo.git #changed via script >>> For readability, you probably would want to have a SP before the >>> given string, i.e., >>> variable = "value" # message comes here >> >> Let me interject... Perhaps also a tab character before the "# >> comment", >> instead of a space character. That would result in even better >> readability. > > Depends on your screen width ;-) Ah, screens are pretty wide these days. :) > If you were trying to tell me that SP or no SP is merely a personal > preference with the comment, I think you succeeded in doing so. Huh, that wasn't my intention. IMHO, a space character between "#" and the actual comment is pretty much mandatory.