From: Ben Peart Date: Fri, 15 Feb 2019 00:14:37 GMT Subject: Re: [PATCH v2] read-cache: add post-indexchanged hook Message-ID: In-Reply-To: On 2/14/2019 3:33 PM, Junio C Hamano wrote: > Ramsay Jones writes: > >> On 14/02/2019 14:42, Ben Peart wrote: >>> From: Ben Peart >>> >>> Add a post-indexchanged hook that is invoked after the index is written in >> >> s/post-indexchanged/post-index-changed/ > > Good. I wasn't paying close attention to the previous round, but is > that the only name-related bikeshedding? I somehow feel that > without s/changed/change/ the name does not roll well on my tongue > and does not sit well together with existing ones like post-receive > (which is not post-received). I dunno. > > Will queue. Thanks. Would you like me to submit another version with the above spelling corrections in the commit message or is it easier to fix it up yourself? > >>> do_write_locked_index(). >>> >>> This hook is meant primarily for notification, and cannot affect >>> the outcome of git commands that trigger the index write. >>> >>> The hook is passed a flag to indicate whether the working directory was >>> updated or not and a flag indicating if a skip-worktree bit could have >>> changed. These flags enable the hook to optmize its response to the >> >> s/optmize/optimize/ >> >> ATB, >> Ramsay Jones