From: Torsten Bögershausen <tboegi@web.de>
Date: Wed, 14 Jun 2017 04:06:49 GMT
Subject: Re: [PATCH v3] doc: do not use `rm .git/index` when normalizing line endings
Message-ID: <dc2070f9-f76f-d569-69f0-61edb7a80610@web.de>
In-Reply-To: <20170613221506.32732-1-asheiduk@gmail.com>



On 14/06/17 00:15, Andreas Heiduk wrote:
Looks good to me, one minor typo below

> When illustrating how to normalize the line endings, the
> documentation in gitattributes tells the user to `rm .git/index`.
> 
> This is incorrect for two reasons:
> 
>   - Users shouldn't be instructed to mess around with the internal
>     implementation of Git using raw file system tools like `rm`.
> 
>   - Within a submodule or an additional working tree `.git` is just a
>     file containing a `gitdir: <path>` pointer into the real `.git`
>     directory.  Therefore `rm .git/index` does not work.
> 
> The purpose or `rm .git/index` instruction is to remove all entries
               ^^
> from the index without touching the working tree.  The way to do this
> with Git is to use `read-tree --empty`.
[]