From: Jeff Hostetler Date: Wed, 11 Sep 2019 18:17:42 GMT Subject: Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command Message-ID: In-Reply-To: <6d1e51c3-64a4-0075-5c9c-3302c5d07c50@gmail.com> On 9/10/2019 9:54 AM, Garima Singh wrote: > Ping :) Any thoughts on this? > > On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote: >> Emit trace2_cmd_mode() messages for each commit-graph sub-command. >> >> The commit graph commands were in flux when trace2 was making it's way to >> git. Now that we have enough sub-commands in commit-graph, we can >> label the >> various modes within them. Distinguishing between read, write and >> verify is >> a great start. >> >> Signed-off-by: Garima Singh garima.singh@microsoft.com >> [garima.singh@microsoft.com] >> >> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com, >> avarab@gmail.com >> >> Garima Singh (1): >>    commit-graph: emit trace2 cmd_mode for each sub-command >> >>   builtin/commit-graph.c | 6 ++++++ >>   1 file changed, 6 insertions(+) >> >> >> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26 >> Published-As: >> https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1 >> >> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git >> pr-323/garimasi514/coreGit-commit-graph-trace2-v1 >> Pull-Request: https://github.com/gitgitgadget/git/pull/323 >> Looks good to me. Thanks! Signed-off-by: Jeff Hostetler