From: Stefan Haller <lists@haller-berlin.de>
Date: Sun, 10 Nov 2024 16:09:12 GMT
Subject: Re: Feature Request: Interactively pick fixup revision
Message-ID: <d9832c11-7c2b-43a8-a7d7-a1de137a5b13@haller-berlin.de>
In-Reply-To: <CABg7He0upi8kmagGO13UMwSWOLeHoryZQU5CGsfbhgqedBKw=Q@mail.gmail.com>

On 10.11.24 08:55, Martin Imre wrote:
> Thanks for pointing me towards https://github.com/keis/git-fixup/ and
> git-absorb (https://github.com/tummychow/git-absorb).
> I'll try them out and see if I like the ergonomics of them.
> 
> Just as a general question: With 2 (or even more) different
> implementations that solve the same problem, wouldn't this be a good
> addition for a future version of git?

I'll throw a third one into the mix: lazygit. It's a TUI client that has
similar functionality built in. (See [1])

As for why this isn't built in: there are a lot of subtleties to how
exactly it works, and people might not agree on these. For example,
git-absorb seems to have certain design goals that I don't agree with; I
have written a longish document about that if you're interested. [2]


[1] <https://github.com/jesseduffield/lazygit/blob/master/
     docs/Fixup_Commits.md#finding-the-commit-to-create-a-fixup-for>

[2] <https://github.com/jesseduffield/lazygit/blob/master/docs/
     dev/Find_Base_Commit_For_Fixup_Design.md>