From: Philip Oakley Date: Fri, 23 Aug 2019 18:46:30 GMT Subject: Re: [PATCH v3 13/13] format-patch: learn --infer-cover-subject option Message-ID: In-Reply-To: <20190823181545.GA14048@archbookpro.localdomain> On 23/08/2019 19:15, Denton Liu wrote: >> Having said that, I suspect that in the longer term, people would >> want to see this new behaviour with a bit of tweak become the new >> default. >> >> The "tweak" I suspect is needed is to behave sensibly when "the >> first line" ends up to be too long a subject. Whether we make this >> the new default or keep this optional, the issue exists either way. > The reason why I chose to make this an "opt-in" option was because there > currently doesn't exist a standard on how to write branch descriptions > like there does for commit messages (i.e. subject then body, subject > less than x characters). However, against best practices, some > developers like to have really long subjects. As a result, there's no > "real" way of telling whether the first paragraph is a long subject or a > short paragraph. > > As a result, we should allow the cover subject to be read from the > branch description only if the developer explicitly chooses this (either > with `--infer-cover-subject` the config option). This way, we won't have > to deal with the ambiguity of deciding whether or not the first > paragraph is truly a subject and stepping on users' toes if we end up > deciding wrong. > > Thoughts? Perhaps the `--infer-cover-subject` the config option needs to be multi-valued to include:      "subject" (always expect short first lines) or      "message" (always the long paragraph description, still use ***Subject Here***),      with the "true" being used when expecting both as previously described. -- Philip As an aside, for format-patch to learn a --branch-version option that creates a branch with the '-vN' suffix to the current branch when the -vN option is used would be a useful addition (as long as the formatted refs are first parent to the current branch). #todo list #leftoverbits