From: Dragan Simic Date: Wed, 17 Jan 2024 22:02:00 GMT Subject: Re: [PATCH] push: improve consistency of output when "up to date" Message-ID: In-Reply-To: On 2024-01-11 22:43, Taylor Blau wrote: > On Thu, Jan 11, 2024 at 09:27:29PM +0000, Benji Kay via GitGitGadget > wrote: >> From: okaybenji >> >> When one issues the pull command, one may see "Already up to date." >> When issuing the push command, one may have seen "Everything >> up-to-date". >> To improve consistency, "Everything up to date." is printed instead. >> (The hyphens have been removed, and a period has been added.) >> >> Signed-off-by: okaybenji >> --- >> push: improve consistency of output when "up to date" >> >> Published-As: >> https://github.com/gitgitgadget/git/releases/tag/pr-1638%2Fokaybenji%2Fup-to-date-v1 >> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git >> pr-1638/okaybenji/up-to-date-v1 >> Pull-Request: https://github.com/gitgitgadget/git/pull/1638 >> >> transport.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/transport.c b/transport.c >> index bd7899e9bf5..c42cb4e58b4 100644 >> --- a/transport.c >> +++ b/transport.c >> @@ -1467,7 +1467,7 @@ int transport_push(struct repository *r, >> if (porcelain && !push_ret) >> puts("Done"); >> else if (!quiet && !ret && !transport_refs_pushed(remote_refs)) >> - fprintf(stderr, "Everything up-to-date\n"); >> + fprintf(stderr, "Everything up to date.\n"); > > Between the two, I have a vague preference towards "up-to-date", which > would suggest changing the pull command's output to read "Already > up-to-date". Personally I think that neither of them should include a > period in their output, but whichever we decide should be done so > consistently between the two. I'm not a native English speaker, but I spent years contributing to English Wikipedia. According to the manual of style employed by Wikipedia, which is based mainly on The Chicago Manual of Style, hyphenated forms should not be used at the ends of sentences, or at the ends of sentence-like forms. In this case, we don't have complete sentences. [1] https://www.chicagomanualofstyle.org/home.html