From: Ramsay Jones Date: Fri, 06 Mar 2026 18:00:50 GMT Subject: Re: [PATCH 5/4] meson: turn on NO_MMAP when building with LSan Message-ID: In-Reply-To: <20260306162513.GB3483423@coredump.intra.peff.net> On 06/03/2026 4:25 pm, Jeff King wrote: > On Fri, Mar 06, 2026 at 01:17:24AM -0800, Jacob Keller wrote: > [snip] >> Also I think this might be somewhat less flexible than Make since you >> can't forcibly enable mmap even with sanitizers enabled. I suppose thats >> not a big deal since enabling sanitizers already has a high cost. > > I don't pay much attention to the meson support, but yeah, it looks like > there's no equivalent to tweak the NO_MMAP knob independently there. I > doubt anybody is clamoring for it. Ignoring old Cygwin, IRIX, IRIX64, Minix, Nonstop and OS/390 set NO_MMAP in the config.mak.uname file. I suspect none of them are using meson to build git, so it shouldn't be an issue. (although I don't quite know why I suspect that!). [NOTE that NO_MMAP is not set in GIT-BUILD-OPTIONS, so ...] ATB, Ramsay Jones