From: Derrick Stolee Date: Tue, 19 Jun 2018 15:21:09 GMT Subject: Re: [PATCH 01/15] contrib: add cocci script to replace index compat macros Message-ID: In-Reply-To: On 6/19/2018 10:51 AM, Duy Nguyen wrote: > On Tue, Jun 19, 2018 at 1:41 PM Derrick Stolee wrote: >> Duy, >> >> Here is the patch that was generated by `make coccicheck`. >> >> Thanks, >> -Stolee >> >> -->8-- >> >> --- builtin/add.c > Ah right. This is on purpose. I think I mentioned in the commit > message that builtin/ is not touched. Do we run 'make coccicheck' > automatically somewhere? If true, I need to move this script elsewhere > because it's meant to run manually. You run it when you intend to do > more manual fixups afterwards. For builtin/, I think I'll wait until > 'struct repository *' conversion is complete then maybe fix them one > by one. I don't think it is part of the CI runs, but some community members run this themselves on 'next' and 'master'. I'm CC'ing Szeder, as he has contributed a fix to my own Coccinelle script [1]. [1] https://public-inbox.org/git/20180430093153.13040-1-szeder.dev@gmail.com/     [PATCH] coccinelle: avoid wrong transformation suggestions from commit.cocci