From: Jakub Narębski Date: Mon, 01 Aug 2016 08:57:02 GMT Subject: Re: [PATCH 1/2] pager: move pager-specific setup into the build Message-ID: In-Reply-To: <20160801070037.GA18261@starla> W dniu 01.08.2016 o 09:00, Eric Wong pisze: > "brian m. carlson" wrote: >> On Mon, Aug 01, 2016 at 01:05:56AM +0000, Eric Wong wrote: >>> + while (*cp && *cp == ' ') >>> + cp++; >> >> So it looks like this function splits on spaces but doesn't provide any >> escaping mechanism. Is there any case in which we want to accept >> environment variables containing whitespace? I ask this as someone that >> has EDITOR set to "gvim -f" on occasion and seeing how tools sometimes >> handle that poorly. This is to handle environment variables holding program options, which are usually (but possibly not often) using single character options bundled together, that is, not using spaces. Moreover, it is about holding program options to pager. > > Yes, it's only split on spaces right now. While I don't think > there's any current case where spaces would be useful/desirable; > I suppose a 3rd patch in this series could add support for using > split_cmdline (from alias.c)... Is there any pager that needs spaces in options-set environment variable? Does MORE allow option bundling? -- Jakub Narębski