From: Marc Strapetz <marc.strapetz@syntevo.com>
Date: Sat, 10 Mar 2018 09:18:13 GMT
Subject: Re: git stash push -u always warns "pathspec '...' did not match any files"
Message-ID: <d49b1b73-3d16-f29d-4363-a5dba4853842@syntevo.com>
In-Reply-To: <xmqqwoyk51w4.fsf@gitster-ct.c.googlers.com>

On 09.03.2018 23:18, Junio C Hamano wrote:
> Marc Strapetz <marc.strapetz@syntevo.com> writes:
> 
>> Thanks, I can confirm that the misleading warning message is fixed.
>>
>> What I've noticed now is that when using -u option, Git won't warn if
>> the pathspec is actually not matching a file. Also, an empty stash may
>> be created.
> 
> Soooo..., does it mean that the patch Thomas posted and you
> confirmed trades one issue with another issue with a similar
> graveness?

 From my understanding these are two separate problems for which the new 
one was somewhat hidden by the one Thomas has fixed: Thomas has fixed 
post-processing code after the stash has already been saved away. The 
problem I'm referring to is a missing check for invalid paths before the 
stash is saved away.

-Marc