From: Scott Chacon <schacon@gmail.com>
Date: Fri, 19 Mar 2010 19:08:18 GMT
Subject: Re: [PATCH] Prompt for a username when an HTTP request 401s
Message-ID: <d411cc4a1003191208m38b7baf2mbb8f1ea288f90819@mail.gmail.com>
In-Reply-To: <20100319143205.GB16211@spearce.org>

Hey,

On Fri, Mar 19, 2010 at 7:32 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Scott Chacon <schacon@gmail.com> wrote:
>> @@ -815,7 +815,18 @@ static int http_request(const char *url, void
>> *result, int target, int options)
>>                       ret = HTTP_OK;
>>               else if (missing_target(&results))
>>                       ret = HTTP_MISSING_TARGET;
>> -             else
>> +             else if (results.http_code == 401) {
>> +                     if (user_name) {
>> +                             ret = HTTP_NOAUTH;
>> +                     } else {
>> +                             // it is neccesary to use getpass here because
>> +                             // there appears to be no other clean way to
>> +                             // read/write stdout/stdin
>> +                             user_name = xstrdup(getpass("Username: "));
>
> No, getpass is needed here because its very likely stdin/stdout are
> pipes to our parent process.  So we instead need to use /dev/tty,
> but that is non-portable.  Using getpass() can at least be stubbed
> on other platforms with a different implementation if/when necessary.

Should I roll a new patch for this?

Scott