From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Mon, 04 Nov 2024 09:06:34 GMT
Subject: Re: [PATCH v2] t1016: clean up style
Message-ID: <d37b443b-089d-40c3-ad41-f77a990fbc72@app.fastmail.com>
In-Reply-To: <xmqqcyjbyjdg.fsf@gitster.g>

On Mon, Nov 4, 2024, at 00:42, Junio C Hamano wrote:
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
>>> +	test_expect_success $PREREQ "Verify ${type} ${name}'s sha1 oid" '
>>> +		git --git-dir=repo-sha256/.git rev-parse --output-object-format=sha1
>>> ${sha256_oid} >${name}_sha1 &&
>>> +		test_cmp ${name}_sha1 ${name}_sha1_expected
>>> +	'
>>
>> At this point it _looks like_ some `test_expect_success` are moved
>> around.  But my diff deceives me: all of the eight `test_` are provided
>> in the same order in the preimage and postimage.
>
> Yes, the output from "git show --histogram" seems to match the
> corresponding blocks in preimage and postimage better in this case.

…I’ve known about histogram but never tried it.  It does work well in
this case.  Noted, thanks. :)