From: Michael Wookey Date: Tue, 15 Sep 2009 23:30:51 GMT Subject: Re: Git crashes on pull Message-ID: In-Reply-To: <7vzl8v4y5g.fsf@alter.siamese.dyndns.org> 2009/9/16 Junio C Hamano : > Guido Ostkamp writes: > >> On Tue, 15 Sep 2009, Junio C Hamano wrote: >> >>> Please try this patch, which I have been preparing for later pushout. >>> >>> From: Junio C Hamano >>> Date: Mon, 14 Sep 2009 14:48:15 -0700 >>> Subject: [PATCH] http.c: avoid freeing an uninitialized pointer >>> >>> An earlier 59b8d38 (http.c: remove verification of remote packs) left >>> the variable "url" uninitialized; "goto cleanup" codepath can free it >>> which is not very nice. >>> >>> Signed-off-by: Junio C Hamano >> >> Appears to be working ok now, thanks. > > Thanks. > > The sad part of the story was that this regression was introduced by a > change to work around recent breakage observed when fetching from the http > server github runs, and it was the primary purpose of pushing 1.6.4.3 out. If only I had given it a run with the clang static analyzer earlier :( Here is what Xcode would have shown - http://dl.getdropbox.com/u/1006983/git-clang.png I can make the Xcode project available if anyone is interested.