From: Ben Peart Date: Tue, 17 Apr 2018 18:39:41 GMT Subject: Re: [PATCH v1 0/5] Allocate cache entries from memory pool Message-ID: In-Reply-To: <20180417163400.3875-1-jamill@microsoft.com> On 4/17/2018 12:34 PM, Jameson Miller wrote: > 100K > > Test baseline [4] block_allocation > ------------------------------------------------------------------------------------ > 0002.1: read_cache/discard_cache 1 times 0.03(0.01+0.01) 0.02(0.01+0.01) -33.3% > > 1M: > > Test baseline block_allocation > ------------------------------------------------------------------------------------ > 0002.1: read_cache/discard_cache 1 times 0.23(0.12+0.11) 0.17(0.07+0.09) -26.1% > > 2M: > > Test baseline block_allocation > ------------------------------------------------------------------------------------ > 0002.1: read_cache/discard_cache 1 times 0.45(0.26+0.19) 0.39(0.17+0.20) -13.3% > > > 100K is not a large enough sample size to show the perf impact of this > change, but we can see a perf improvement with 1M and 2M entries. I see a 33% change with 100K files which is a substantial improvement even in the 100K case. I do see that the actual wall clock savings aren't nearly as much with a small repo as it is with the larger repos which makes sense.