From: David Turner Date: Mon, 15 May 2017 21:21:37 GMT Subject: RE: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files. Message-ID: In-Reply-To: <20170515191347.1892-3-benpeart@microsoft.com> > -----Original Message----- > From: Ben Peart [mailto:peartben@gmail.com] > Sent: Monday, May 15, 2017 3:14 PM > To: git@vger.kernel.org > Cc: gitster@pobox.com; benpeart@microsoft.com; pclouds@gmail.com; > johannes.schindelin@gmx.de; David Turner ; > peff@peff.net > Subject: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to > speed up detecting new or changed files. > @@ -342,6 +344,8 @@ struct index_state { > struct hashmap dir_hash; > unsigned char sha1[20]; > struct untracked_cache *untracked; > + time_t last_update; > + struct ewah_bitmap *bitmap; The name 'bitmap' doesn't tell the reader much about what it used for. > +static int update_istate(const char *name, void *is) { Rename to mark_file_dirty? Also why does it take a void pointer? Or return int (rather than void)? > +void refresh_by_fsmonitor(struct index_state *istate) { > + static has_run_once = FALSE; > + struct strbuf buffer = STRBUF_INIT; Rename to query_result? Also I think you're leaking it.